Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: chrome/browser/extensions/api/copresence/copresence_api.cc

Issue 704923002: Add polling and audio check to copresence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/copresence/copresence_api.cc
diff --git a/chrome/browser/extensions/api/copresence/copresence_api.cc b/chrome/browser/extensions/api/copresence/copresence_api.cc
index 8fb4faccb7cd9e5e1a573105073ff8a42b1e3859..502fa4eae19f6f1a3af38a475d29ad351f0bd689 100644
--- a/chrome/browser/extensions/api/copresence/copresence_api.cc
+++ b/chrome/browser/extensions/api/copresence/copresence_api.cc
@@ -115,6 +115,21 @@ void CopresenceService::HandleMessages(
<< app_id << "\" for subscription \"" << subscription_id << "\"";
}
+void CopresenceService::HandleStatusUpdate(
+ copresence::CopresenceStatus status) {
+ // Update all apps using copresence with the new status update.
+ for (const std::string& app_id : copresence_apps_) {
+ scoped_ptr<Event> event(
+ new Event(api::copresence::OnStatusUpdated::kEventName,
+ api::copresence::OnStatusUpdated::Create(
+ api::copresence::STATUS_AUDIOFAILED),
+ browser_context_));
+ EventRouter::Get(browser_context_)
+ ->DispatchEventToExtension(app_id, event.Pass());
+ DVLOG(2) << "Sent Audio Failed status update to app_id: " << app_id;
+ }
+}
+
net::URLRequestContextGetter* CopresenceService::GetRequestContext() const {
return browser_context_->GetRequestContext();
}
@@ -167,6 +182,7 @@ ExtensionFunction::ResponseAction CopresenceExecuteFunction::Run() {
return RespondNow(Error(kInvalidOperationsMessage));
}
+ service->copresence_apps().insert(extension_id());
xiyuan 2014/11/06 21:27:50 When do we remove the app id from service?
rkc 2014/11/06 21:45:05 I just realized that we don't need this code at al
service->manager()->ExecuteReportRequest(
request,
extension_id(),

Powered by Google App Engine
This is Rietveld 408576698