Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: components/copresence/rpc/rpc_handler_unittest.cc

Issue 704923002: Add polling and audio check to copresence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/rpc/rpc_handler_unittest.cc
diff --git a/components/copresence/rpc/rpc_handler_unittest.cc b/components/copresence/rpc/rpc_handler_unittest.cc
index 63d8824d07aa070dfb80232ba210cee969206a40..da1efb89bc3b16e4af098e97f0fd6ac2f9cce865 100644
--- a/components/copresence/rpc/rpc_handler_unittest.cc
+++ b/components/copresence/rpc/rpc_handler_unittest.cc
@@ -52,7 +52,8 @@ class FakeDirectiveHandler final : public DirectiveHandler {
return added_directives_;
}
- void Start(WhispernetClient* /* whispernet_client */) override {
+ void Start(WhispernetClient* /* whispernet_client */,
+ const TokensCallback& /* tokens_cb */) override {
NOTREACHED();
}
@@ -68,6 +69,8 @@ class FakeDirectiveHandler final : public DirectiveHandler {
return type == AUDIBLE ? "current audible" : "current inaudible";
}
+ bool IsAudioTokenHeard(AudioType type) const override { return true; }
+
private:
std::vector<std::string> added_directives_;
@@ -79,12 +82,12 @@ class FakeDirectiveHandler final : public DirectiveHandler {
class RpcHandlerTest : public testing::Test, public CopresenceDelegate {
public:
RpcHandlerTest()
- : whispernet_client_(new StubWhispernetClient),
- rpc_handler_(this,
- &directive_handler_,
- base::Bind(&RpcHandlerTest::CaptureHttpPost,
- base::Unretained(this))),
- status_(SUCCESS) {}
+ : whispernet_client_(new StubWhispernetClient),
+ rpc_handler_(this,
+ &directive_handler_,
+ base::Bind(&RpcHandlerTest::CaptureHttpPost,
+ base::Unretained(this))),
+ status_(SUCCESS) {}
// CopresenceDelegate implementation
@@ -97,6 +100,8 @@ class RpcHandlerTest : public testing::Test, public CopresenceDelegate {
}
}
+ void HandleStatusUpdate(CopresenceStatus /* status */) override{};
Charlie 2014/11/06 17:28:24 override {} No semicolon
rkc 2014/11/06 19:58:25 Done.
+
net::URLRequestContextGetter* GetRequestContext() const override {
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698