Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3491)

Unified Diff: content/renderer/pepper/ppb_video_decoder_impl.h

Issue 704913002: PPAPI: Make GetProxiedInterface not re-enter the plugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Oops, make SimulateInputEvent async again Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/pepper/ppb_video_decoder_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/ppb_video_decoder_impl.h
diff --git a/content/renderer/pepper/ppb_video_decoder_impl.h b/content/renderer/pepper/ppb_video_decoder_impl.h
index e3037b9eb5a85c70ed19001938ea184ab7ea5207..094bcff7b43efa3e424b4b4aa32c4ee81fbb6b2d 100644
--- a/content/renderer/pepper/ppb_video_decoder_impl.h
+++ b/content/renderer/pepper/ppb_video_decoder_impl.h
@@ -58,12 +58,19 @@ class PPB_VideoDecoder_Impl : public ppapi::PPB_VideoDecoder_Shared,
explicit PPB_VideoDecoder_Impl(PP_Instance instance);
bool Init(PP_Resource graphics_context,
PP_VideoDecoder_Profile profile);
+ // Returns the associated PPP_VideoDecoder_Dev interface to use when
+ // making calls on the plugin. This fetches the interface lazily. For
+ // out-of-process plugins, this means a synchronous message to the plugin,
+ // so it's important to never call this in response to a synchronous
+ // plugin->renderer message (such as the Create message).
+ const PPP_VideoDecoder_Dev* GetPPP();
// This is NULL before initialization, and after destruction.
// Holds a GpuVideoDecodeAcceleratorHost.
scoped_ptr<media::VideoDecodeAccelerator> decoder_;
- // Reference to the plugin requesting this interface.
+ // The interface to use when making calls on the plugin. For the most part,
+ // methods should not use this directly but should call GetPPP() instead.
const PPP_VideoDecoder_Dev* ppp_videodecoder_;
DISALLOW_COPY_AND_ASSIGN(PPB_VideoDecoder_Impl);
« no previous file with comments | « no previous file | content/renderer/pepper/ppb_video_decoder_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698