Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 7049017: Merge 86358 - 2011-05-12 Carol Szabo <carol@webkit.org> (Closed)

Created:
8 years, 4 months ago by Cris Neckar
Modified:
8 years, 4 months ago
Reviewers:
Cris Neckar
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/742/
Visibility:
Public.

Description

Merge 86358 - 2011-05-12 Carol Szabo <carol@webkit.org>; Reviewed by David Hyatt. Fix reparenting and destruction of counter nodes. https://bugs.webkit.org/show_bug.cgi?id=57929 Fixed several issues related to not met assertions. See below in the per file description. Test: fast/css/counters/element-removal-crash.xhtml * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Fixed the fact that Node::detach() used to be called while the DOM tree was in an inconsistent state. * rendering/RenderCounter.cpp: (WebCore::RenderCounter::rendererRemovedFromTree): Introduced this function to remove counters from descendents of renderers removed from the renderer tree not only from the removed renderers themselves. * rendering/RenderCounter.h: * rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Changed to call RenderCounter::rendererRemovedFromTree instead of RenderCounter::destroyCounters. BUG=78572 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
A + LayoutTests/fast/css/counters/element-removal-crash.xhtml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/css/counters/element-removal-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/dom/ContainerNode.cpp View 1 chunk +16 lines, -6 lines 0 comments Download
M Source/WebCore/rendering/RenderCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderCounter.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderObjectChildList.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Cris Neckar
8 years, 4 months ago (2011-05-19 18:43:43 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698