Domain Reliability: Switch to BackoffEntry in Scheduler

Domain Reliability: Switch to BackoffEntry in Scheduler

Previously, Domain Reliability was using homegrown backoff handling code.
Switch to using the existing BackoffEntry.

BUG=

Committed: https://crrev.com/dd6819b1522473ae11b98cb60b8b613af01f4b56
Cr-Commit-Position: refs/heads/master@{#303296}

[Deprecated (see juliatuttle), 2014-11-05 23:05:03]

ttuttle@chromium.org changed reviewers:
+ davidben@chromium.org

[Deprecated (see juliatuttle), 2014-11-05 23:05:03]

ttuttle@chromium.org changed required reviewers:
+ davidben@chromium.org

[Deprecated (see juliatuttle), 2014-11-05 23:05:03]

PTAL, davidben.

[davidben, 2014-11-06 22:39:36]

https://codereview.chromium.org/704893002/diff/1/components/domain_reliabilit...
File components/domain_reliability/scheduler.cc (right):

https://codereview.chromium.org/704893002/diff/1/components/domain_reliabilit...
components/domain_reliability/scheduler.cc:85: backoff_policy_.entry_lifetime_ms
= 60 * 60 * 1000;
Nit: maybe pull these up into constants.

https://codereview.chromium.org/704893002/diff/1/components/domain_reliabilit...
components/domain_reliability/scheduler.cc:181: data->Set("collectors",
collectors); */
Did you mean to delete this code or revise it?

[Deprecated (see juliatuttle), 2014-11-07 19:45:09]

PTAL, davidben.

https://codereview.chromium.org/704893002/diff/1/components/domain_reliabilit...
File components/domain_reliability/scheduler.cc (right):

https://codereview.chromium.org/704893002/diff/1/components/domain_reliabilit...
components/domain_reliability/scheduler.cc:85: backoff_policy_.entry_lifetime_ms
= 60 * 60 * 1000;
On 2014/11/06 22:39:36, David Benjamin wrote:
> Nit: maybe pull these up into constants.

Done.

https://codereview.chromium.org/704893002/diff/1/components/domain_reliabilit...
components/domain_reliability/scheduler.cc:181: data->Set("collectors",
collectors); */
On 2014/11/06 22:39:36, David Benjamin wrote:
> Did you mean to delete this code or revise it?

Revise; it turns out it's fairly simple, so done.

[davidben, 2014-11-07 20:06:04]

lgtm

https://codereview.chromium.org/704893002/diff/60001/components/domain_reliab...
File components/domain_reliability/scheduler.cc (right):

https://codereview.chromium.org/704893002/diff/60001/components/domain_reliab...
components/domain_reliability/scheduler.cc:90: backoff_policy_.entry_lifetime_ms
= 0;
Just to confirm, this bit is a no-op from patch set 1 since you never call
CanDiscard(), correct?

[Deprecated (see juliatuttle), 2014-11-07 20:42:58]

On 2014/11/07 20:06:04, David Benjamin wrote:
> lgtm
> 
>
https://codereview.chromium.org/704893002/diff/60001/components/domain_reliab...
> File components/domain_reliability/scheduler.cc (right):
> 
>
https://codereview.chromium.org/704893002/diff/60001/components/domain_reliab...
> components/domain_reliability/scheduler.cc:90:
backoff_policy_.entry_lifetime_ms
> = 0;
> Just to confirm, this bit is a no-op from patch set 1 since you never call
> CanDiscard(), correct?

Correct.

[Deprecated (see juliatuttle), 2014-11-07 20:43:14]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2014-11-07 20:44:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/704893002/60001

[commit-bot: I haz the power, 2014-11-07 21:34:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-07 21:35:12]

Patchset 4 (id:??) landed as
https://crrev.com/dd6819b1522473ae11b98cb60b8b613af01f4b56
Cr-Commit-Position: refs/heads/master@{#303296}

[raymes, 2014-11-10 01:11:30]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/709333003/ by raymes@chromium.org.

The reason for reverting is: Speculative revert to attempt to fix
https://code.google.com/p/chromium/issues/detail?id=431608.