chrome/browser/policy/configuration_policy_handler_list_factory.cc - Issue 704883002: Exclude spellcheck related code properly on android/ios which doesn't have spellchecker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_handler_list_factory.cc

Issue 704883002: Exclude spellcheck related code properly on android/ios which doesn't have spellchecker (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/policy/configuration_policy_handler_list_factory.cc

diff --git a/chrome/browser/policy/configuration_policy_handler_list_factory.cc b/chrome/browser/policy/configuration_policy_handler_list_factory.cc

index 6bb665332a0176164b7406dd5e447362f9ab4163..a8f347d9528744a3966cfd57ab8708f2a6c75b96 100644

--- a/chrome/browser/policy/configuration_policy_handler_list_factory.cc

+++ b/chrome/browser/policy/configuration_policy_handler_list_factory.cc

@@ -336,9 +336,11 @@ const PolicyToPreferenceMapEntry kSimplePolicyMap[] = {

{ key::kDisableSafeBrowsingProceedAnyway,

prefs::kSafeBrowsingProceedAnywayDisabled,

base::Value::TYPE_BOOLEAN },

+#if defined(ENABLE_SPELLCHECK)

bartfab (slow) 2014/11/07 16:25:22 Nit: Please add blank lines above and below this #

oshima 2014/11/07 18:51:36 Done.

{ key::kSpellCheckServiceEnabled,

prefs::kSpellCheckUseSpellingService,

base::Value::TYPE_BOOLEAN },

+#endif

bartfab (slow) 2014/11/07 16:25:22 Nit: Please add // defined(ENABLE_SPELLCHECK) to s

oshima 2014/11/07 18:51:36 Done.

{ key::kDisableScreenshots,

prefs::kDisableScreenshots,

base::Value::TYPE_BOOLEAN },

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »