Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 704883002: Exclude spellcheck related code properly on android/ios which doesn't have spellchecker (Closed)

Created:
6 years, 1 month ago by oshima
Modified:
6 years, 1 month ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Exclude spellcheck related code properly on android/ios which doesn't have spellchecker BUG=397227 Committed: https://crrev.com/66a9f969936e09b6751b166bef6dcc9d2154ab36 Cr-Commit-Position: refs/heads/master@{#303277}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
oshima
6 years, 1 month ago (2014-11-05 23:56:48 UTC) #5
oshima
friendly ping
6 years, 1 month ago (2014-11-07 06:52:04 UTC) #6
bartfab (slow)
lgtm https://codereview.chromium.org/704883002/diff/60001/chrome/browser/policy/configuration_policy_handler_list_factory.cc File chrome/browser/policy/configuration_policy_handler_list_factory.cc (right): https://codereview.chromium.org/704883002/diff/60001/chrome/browser/policy/configuration_policy_handler_list_factory.cc#newcode339 chrome/browser/policy/configuration_policy_handler_list_factory.cc:339: #if defined(ENABLE_SPELLCHECK) Nit: Please add blank lines above ...
6 years, 1 month ago (2014-11-07 16:25:22 UTC) #7
oshima
https://codereview.chromium.org/704883002/diff/60001/chrome/browser/policy/configuration_policy_handler_list_factory.cc File chrome/browser/policy/configuration_policy_handler_list_factory.cc (right): https://codereview.chromium.org/704883002/diff/60001/chrome/browser/policy/configuration_policy_handler_list_factory.cc#newcode339 chrome/browser/policy/configuration_policy_handler_list_factory.cc:339: #if defined(ENABLE_SPELLCHECK) On 2014/11/07 16:25:22, bartfab wrote: > Nit: ...
6 years, 1 month ago (2014-11-07 18:51:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704883002/80001
6 years, 1 month ago (2014-11-07 18:52:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years, 1 month ago (2014-11-07 20:01:22 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 20:02:05 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/66a9f969936e09b6751b166bef6dcc9d2154ab36
Cr-Commit-Position: refs/heads/master@{#303277}

Powered by Google App Engine
This is Rietveld 408576698