Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/PNaClTranslator.cpp

Issue 704753007: Subzero: Improve the use of NodeList objects. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceCfg.cpp ('K') | « src/IceTargetLoweringX8632.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index f2d8e0cbf2b9d7d54896249bfc1cdb298826ef1b..68a1ebc0193643f0fc992427d903d092004d33ce 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -1637,7 +1637,7 @@ void FunctionParser::ExitBlock() {
// insert unreachable. This shouldn't happen, but be safe.
unsigned Index = 0;
for (Ice::CfgNode *Node : Func->getNodes()) {
- if (Node->getInsts().size() == 0) {
+ if (Node->getInsts().empty()) {
std::string Buffer;
raw_string_ostream StrBuf(Buffer);
StrBuf << "Basic block " << Index << " contains no instructions";
@@ -1908,7 +1908,7 @@ void FunctionParser::ProcessRecord() {
// RET: [opval?]
if (!isValidRecordSizeInRange(0, 1, "function block ret"))
return;
- if (Values.size() == 0) {
+ if (Values.empty()) {
CurrentNode->appendInst(Ice::InstRet::create(Func));
} else {
CurrentNode->appendInst(
« src/IceCfg.cpp ('K') | « src/IceTargetLoweringX8632.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698