Source/core/frame/csp/CSPDirectiveList.cpp - Issue 704723003: Revert "Allow CSP checkNonce and checkHash to pass with 'unsafe-inline' only."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/csp/CSPDirectiveList.cpp

Issue 704723003: Revert "Allow CSP checkNonce and checkHash to pass with 'unsafe-inline' only." (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scriptnonce-multiple-policies-with-unsafe-inline-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/csp/CSPDirectiveList.cpp

diff --git a/Source/core/frame/csp/CSPDirectiveList.cpp b/Source/core/frame/csp/CSPDirectiveList.cpp

index d4997139ea2c241433834f1b00cd53e88ee29a24..6ff0e090f14ddd5949f55846a98e51f57e298fad 100644

--- a/Source/core/frame/csp/CSPDirectiveList.cpp

+++ b/Source/core/frame/csp/CSPDirectiveList.cpp

@@ -86,12 +86,12 @@ bool CSPDirectiveList::checkInline(SourceListDirective* directive) const

bool CSPDirectiveList::checkNonce(SourceListDirective* directive, const String& nonce) const

{

- return !directive || directive->allowNonce(nonce) || checkInline(directive);

+ return !directive || directive->allowNonce(nonce);

}

bool CSPDirectiveList::checkHash(SourceListDirective* directive, const CSPHashValue& hashValue) const

{

- return !directive || directive->allowHash(hashValue) || checkInline(directive);

+ return !directive || directive->allowHash(hashValue);

}

bool CSPDirectiveList::checkSource(SourceListDirective* directive, const KURL& url) const