Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 704703002: [x64] 64-bit shift left by 32 or more covers sign/zero extend. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[x64] 64-bit shift left by 32 or more covers sign/zero extend. TEST=unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-05 05:32:57 UTC) #2
Jarin
lgtm
6 years, 1 month ago (2014-11-05 05:57:25 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-05 05:58:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25123 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698