Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 704693003: Correct line width calculation with inline-block induced word spacing (Closed)

Created:
6 years, 1 month ago by trchen
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Correct line width calculation with inline-block induced word spacing A previous CL allowed word spacing to be added around inline-blocks. However the line width calculation wasn't consistent with children placement, and contents will overflow on the right side of the line if there was inline-block induced word spacing. This CL makes RenderBlockFlow::computeInlineDirectionPositionsForSegment to be consistent with InlineFlowBox::placeBoxRangeInInlineDirection. BUG=429655 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A LayoutTests/fast/css/word-spacing-inline-box-line-width.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/word-spacing-inline-box-line-width-expected.html View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
trchen
Hello reviewers, this is a one-line fix for a word spacing bug. PTAL. Thanks!
6 years, 1 month ago (2014-11-05 04:02:10 UTC) #2
leviw_travelin_and_unemployed
Totally. Makes sense. LGTM.
6 years, 1 month ago (2014-11-05 06:41:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704693003/1
6 years, 1 month ago (2014-11-05 06:41:33 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 07:44:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184853

Powered by Google App Engine
This is Rietveld 408576698