Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 704693002: ServiceWorker: Disable ServiceWorkerMicroBenchmarkPerfTest (Closed)

Created:
6 years, 1 month ago by nhiroki
Modified:
6 years, 1 month ago
Reviewers:
dtu, horo
CC:
chromium-reviews, telemetry+watch_chromium.org, shimazu
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Disable ServiceWorkerMicroBenchmarkPerfTest many-registration.html is failing due to out-of-memory error. BUG=430232 TBR=dtu@chromium.org Committed: https://crrev.com/bb04107761cec15ad533cc2bd6258f462443bf49 Cr-Commit-Position: refs/heads/master@{#302751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
nhiroki
ptal, thanks!
6 years, 1 month ago (2014-11-05 01:51:52 UTC) #2
horo
lgtm Thank you!
6 years, 1 month ago (2014-11-05 02:25:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704693002/1
6 years, 1 month ago (2014-11-05 02:26:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22198)
6 years, 1 month ago (2014-11-05 02:32:13 UTC) #7
nhiroki
+dtu@: Let me use TBR because this just disables the failed test.
6 years, 1 month ago (2014-11-05 03:03:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704693002/1
6 years, 1 month ago (2014-11-05 03:04:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 03:53:11 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 03:53:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb04107761cec15ad533cc2bd6258f462443bf49
Cr-Commit-Position: refs/heads/master@{#302751}

Powered by Google App Engine
This is Rietveld 408576698