Issue 70463002: "Fix" another crash on valgrind bot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 70463002: "Fix" another crash on valgrind bot (Closed)

Created:
7 years, 1 month ago by robertphillips

Modified:
7 years, 1 month ago

Reviewers:
jvanverth1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The valgrind bot is now crashing in the DeferredCanvasTest: Process terminating with default action of signal 11 (SIGSEGV) Access not within mapped region at address 0x18 at 0x5819C3: SkSurface::getCanvas() (SkSurface_Base.h:75) by 0x64D5B6: DeferredDevice::DeferredDevice(SkSurface*) (SkDeferredCanvas.cpp:277) by 0x64FA32: SkDeferredCanvas::Create(SkSurface*) (SkDeferredCanvas.cpp:554) by 0x42BE4E: TestDeferredCanvasSurface(skiatest::Reporter*, GrContextFactory*) (DeferredCanvasTest.cpp:716) by 0x42D453: skiatest::TestDeferredCanvasClass::onRun(skiatest::Reporter*) (DeferredCanvasTest.cpp:842) by 0x4966FA: skiatest::Test::run() (Test.cpp:109) by 0x48FD90: SkTestRunnable::run() (skia_test.cpp:155) by 0x48F736: tool_main(int, char**) (skia_test.cpp:246) by 0x48F912: main (skia_test.cpp:276)

Patch Set 1 #

Patch Set 2 : Actually do it right this time #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tests/DeferredCanvasTest.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

committed as r12248

Expand Messages | Collapse Messages