Add advanced details to the SSL clock interstitial.

Add advanced details to the SSL clock interstitial.

BUG=414843
Committed: https://crrev.com/5d5675bf978f9558772b2dc8f7630ee9db5e4862
Cr-Commit-Position: refs/heads/master@{#302724}

[lgarron, 2014-11-04 21:24:52]

lgarron@chromium.org changed reviewers:
+ felt@chromium.org

[felt, 2014-11-04 21:59:08]

lgtm % formatting

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:427: 
nit: no need for this extra newline between the comment & code

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:432: load_time_data.SetString(
these are indented too much

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:440: 
nit: no need for this extra newline between the comment & code

[lgarron, 2014-11-04 22:06:14]

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:427: 
On 2014/11/04 21:59:08, felt wrote:
> nit: no need for this extra newline between the comment & code

"No need" or "preferred"? (I like to keep my code pretty spaced out, even when
I'm adapting to other code styles.)

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:432: load_time_data.SetString(
On 2014/11/04 21:59:08, felt wrote:
> these are indented too much

Yeah, the third patch took me a while to upload because building (just for a
sanity check) failed and I had to build from scratch. :-(

[felt, 2014-11-04 22:15:29]

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:427: 
On 2014/11/04 22:06:14, lgarron wrote:
> On 2014/11/04 21:59:08, felt wrote:
> > nit: no need for this extra newline between the comment & code
> 
> "No need" or "preferred"? (I like to keep my code pretty spaced out, even when
> I'm adapting to other code styles.)

The style is to not have spaces between comments and code blocks.

[lgarron, 2014-11-04 22:21:20]

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/704623002/diff/20001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:427: 
On 2014/11/04 22:15:29, felt wrote:
> On 2014/11/04 22:06:14, lgarron wrote:
> > On 2014/11/04 21:59:08, felt wrote:
> > > nit: no need for this extra newline between the comment & code
> > 
> > "No need" or "preferred"? (I like to keep my code pretty spaced out, even
when
> > I'm adapting to other code styles.)
> 
> The style is to not have spaces between comments and code blocks.

Has anyone thought about, y'know, putting this stuff in the style guide? :-P
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Comment_Style

[lgarron, 2014-11-04 23:40:43]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2014-11-04 23:42:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/704623002/60001

[commit-bot: I haz the power, 2014-11-05 00:50:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-05 00:51:31]

Patchset 4 (id:??) landed as
https://crrev.com/5d5675bf978f9558772b2dc8f7630ee9db5e4862
Cr-Commit-Position: refs/heads/master@{#302724}