Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 7046064: Some small refactoring and renaming of sel_universel pepper emulation components. (Closed)

Created:
9 years, 6 months ago by robertm
Modified:
9 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Some small refactoring and renaming of sel_universel pepper emulation components. This is in anticipation of making some pepper emulation (e.g. file access) independent of the availability of SDL which is only used for video and audio. Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5613

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1301 lines) Patch
M src/trusted/sel_universal/build.scons View 1 1 chunk +3 lines, -2 lines 0 comments Download
D src/trusted/sel_universal/multimedia.h View 1 1 chunk +0 lines, -67 lines 0 comments Download
D src/trusted/sel_universal/multimedia_handler.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
D src/trusted/sel_universal/multimedia_handler.cc View 1 1 chunk +0 lines, -692 lines 0 comments Download
D src/trusted/sel_universal/multimedia_sdl.cc View 1 1 chunk +0 lines, -423 lines 0 comments Download
A src/trusted/sel_universal/non_standard_pepper_events.cc View 1 1 chunk +81 lines, -0 lines 0 comments Download
M src/trusted/sel_universal/pepper_emu_core.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/trusted/sel_universal/pepper_emu_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/trusted/sel_universal/pepper_emu_handler.cc View 3 chunks +5 lines, -3 lines 0 comments Download
A + src/trusted/sel_universal/primitives.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/trusted/sel_universal/primitives_sdl.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/sel_universal/sdl_ppapi_event_translator.cc View 1 2 chunks +2 lines, -66 lines 0 comments Download
M src/trusted/sel_universal/sel_universal.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertm
PTAL
9 years, 6 months ago (2011-06-08 22:54:29 UTC) #1
robertm
+ eugenis
9 years, 6 months ago (2011-06-09 14:26:24 UTC) #2
Sang Ahn
http://codereview.chromium.org/7046064/diff/1/src/trusted/sel_universal/non_standard_pepper_events.cc File src/trusted/sel_universal/non_standard_pepper_events.cc (right): http://codereview.chromium.org/7046064/diff/1/src/trusted/sel_universal/non_standard_pepper_events.cc#newcode7 src/trusted/sel_universal/non_standard_pepper_events.cc:7: // This file provives a utilty function to translate ...
9 years, 6 months ago (2011-06-09 20:34:48 UTC) #3
robertm
PTAL http://codereview.chromium.org/7046064/diff/1/src/trusted/sel_universal/non_standard_pepper_events.cc File src/trusted/sel_universal/non_standard_pepper_events.cc (right): http://codereview.chromium.org/7046064/diff/1/src/trusted/sel_universal/non_standard_pepper_events.cc#newcode7 src/trusted/sel_universal/non_standard_pepper_events.cc:7: // This file provives a utilty function to ...
9 years, 6 months ago (2011-06-09 21:02:21 UTC) #4
Sang Ahn
9 years, 6 months ago (2011-06-09 21:53:03 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698