Source/bindings/templates/union.h - Issue 704503002: IDL: Union type support for attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/union.h

Issue 704503002: IDL: Union type support for attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@union-arraybuffer

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/union.h

diff --git a/Source/bindings/templates/union.h b/Source/bindings/templates/union.h

index 8db42b44440da1776484f0ab3943b7d77f82b09d..5cb527951b64f2bd57521e9ba4f9a7b47b41dc2e 100644

--- a/Source/bindings/templates/union.h

+++ b/Source/bindings/templates/union.h

@@ -26,7 +26,7 @@ public:

{% for member in container.members %}

bool is{{member.type_name}}() const { return m_type == {{member.specific_type_enum}}; }

- {{member.rvalue_cpp_type}} getAs{{member.type_name}}();

+ {{member.rvalue_cpp_type}} getAs{{member.type_name}}() const;

bashi 2014/11/04 11:32:48 Need "const" for argument setters like below: voi

void set{{member.type_name}}({{member.rvalue_cpp_type}});

{% endfor %}

« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/union.cpp » ('j') | no next file with comments »