Source/bindings/scripts/v8_interface.py - Issue 704503002: IDL: Union type support for attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 704503002: IDL: Union type support for attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@union-arraybuffer

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 1a28f425a53357377d56022c97e58c6b2fe2509e..7e86bcf1918321cf0d4c97be1d8d463f3c7e6cf4 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -1044,7 +1044,7 @@ def interface_length(interface, constructors):

def property_getter(getter, cpp_arguments):

def is_null_expression(idl_type):

- if v8_methods.use_output_parameter_for_result(idl_type):

+ if idl_type.use_output_parameter_for_result:

return 'result.isNull()'

if idl_type.name == 'String':

return 'result.isNull()'

@@ -1055,7 +1055,7 @@ def property_getter(getter, cpp_arguments):

idl_type = getter.idl_type

extended_attributes = getter.extended_attributes

is_raises_exception = 'RaisesException' in extended_attributes

- use_output_parameter_for_result = v8_methods.use_output_parameter_for_result(idl_type)

+ use_output_parameter_for_result = idl_type.use_output_parameter_for_result

# FIXME: make more generic, so can use v8_methods.cpp_value

cpp_method_name = 'impl->%s' % cpp_name(getter)

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »