Issue 704463004: [turbofan] Turn various diamonds into selects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 704463004: [turbofan] Turn various diamonds into selects. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

[turbofan] Turn various diamonds into selects. TEST=cctest/test-changes-lowering,mjsunit/asm,unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25180

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -77 lines)			Patch
M	src/compiler/change-lowering.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	src/compiler/js-builtin-reducer.cc	View		2 chunks	+11 lines, -10 lines	0 comments	Download
M	src/compiler/machine-operator-reducer.cc	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	test/cctest/compiler/test-changes-lowering.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	test/unittests/compiler/change-lowering-unittest.cc	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	test/unittests/compiler/js-builtin-reducer-unittest.cc	View		2 chunks	+5 lines, -16 lines	0 comments	Download
M	test/unittests/compiler/machine-operator-reducer-unittest.cc	View		1 chunk	+14 lines, -28 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

6 years, 1 month ago (2014-11-06 09:10:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 25180 (presubmit successful).