Allow extension function call quota to be un-throttled.

extensions/browser/quota_service.h

Index: extensions/browser/quota_service.h
diff --git a/extensions/browser/quota_service.h b/extensions/browser/quota_service.h
index 1dd55699e3eb7e0c427f5904df213674353391a0..33a4abd18e707431bbb26cc386b29dbca2cf2a7d 100644
--- a/extensions/browser/quota_service.h
+++ b/extensions/browser/quota_service.h
@@ -64,12 +64,11 @@ class QuotaService : public base::NonThreadSafe {
   // All QuotaLimitHeuristic instances in this map are owned by us.
   typedef std::map<FunctionName, QuotaLimitHeuristics> FunctionHeuristicsMap;
 
-  // Purge resets all accumulated data (except |violation_errors_|) as if the
-  // service was just created. Called periodically so we don't consume an
-  // unbounded amount of memory while tracking quota.  Yes, this could mean an
-  // extension gets away with murder if it is timed right, but the extensions
-  // we are trying to limit are ones that consistently violate, so we'll
-  // converge to the correct set.
+  // Purge resets all accumulated data as if the service was just created.
+  // Called periodically so we don't consume an unbounded amount of memory
+  // while tracking quota.  Yes, this could mean an extension gets away with
+  // murder if it is timed right, but the extensions we are trying to limit are
+  // ones that consistently violate, so we'll converge to the correct set.

[Nicolas Zea, 2014/11/04 20:33:10]

Is this comment still accurate (particularly the last sentence)?

[not at google - send to devlin, 2014/11/04 22:07:25]

Good point, fixed. Of the last sentence: the last part isn't true anymore, which
means the first part doesn't make sense to say - and I don't think timing
"attacks" like this are interesting anyway.

   void Purge();
   void PurgeFunctionHeuristicsMap(FunctionHeuristicsMap* map);
   base::RepeatingTimer<QuotaService> purge_timer_;
@@ -81,12 +80,6 @@ class QuotaService : public base::NonThreadSafe {
   // Each heuristic will be evaluated and ANDed together to get a final answer.
   std::map<ExtensionId, FunctionHeuristicsMap> function_heuristics_;
 
-  // For now, as soon as an extension violates quota, we don't allow it to
-  // make any more requests to quota limited functions.  This provides a quick
-  // lookup for these extensions that is only stored in memory.
-  typedef std::map<std::string, std::string> ViolationErrorMap;
-  ViolationErrorMap violation_errors_;
-
   DISALLOW_COPY_AND_ASSIGN(QuotaService);
 };