Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 704413010: Deflake LayoutTests/http/tests/security/cross-origin-appcache-allowed.html (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
michaeln
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Deflake LayoutTests/http/tests/security/cross-origin-appcache-allowed.html The iframe load was racing with the main frame setting the onmessage event handler. To fix this, defer the iframe loads until the main frame onmessage event handler has already been set. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M LayoutTests/http/tests/security/cross-origin-appcache-allowed.html View 1 chunk +17 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dcheng
6 years, 1 month ago (2014-11-11 07:06:57 UTC) #2
michaeln
lgtm (nice fix)
6 years, 1 month ago (2014-11-11 21:55:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704413010/1
6 years, 1 month ago (2014-11-11 22:06:37 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 23:09:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185150

Powered by Google App Engine
This is Rietveld 408576698