Issue 704413008: Remove assorted dead code from RenderBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 704413008: Remove assorted dead code from RenderBox. (Closed)

Created:
6 years, 1 month ago by ojan

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove assorted dead code from RenderBox. -overrideContainingBlock sizes were only used by RenderGrid. -percendicular containing blocks were a vertical writing mode feature. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4bfdaf69fbe0d0959a2e5b8239c330d5213a3ec6

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -120 lines)			Patch
M	sky/engine/core/rendering/RenderBox.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBox.cpp	View	9 chunks	+5 lines, -109 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBoxModelObject.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

ojan

6 years, 1 month ago (2014-11-11 03:43:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4bfdaf69fbe0d0959a2e5b8239c330d5213a3ec6 (presubmit successful).