Hooking MHTML generation to the browser.

chrome/browser/download/mhtml_generation_manager.h

Index: chrome/browser/download/mhtml_generation_manager.h
diff --git a/chrome/browser/download/mhtml_generation_manager.h b/chrome/browser/download/mhtml_generation_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..5840c60799d3fdb4fb80ff78e0f7d12bfa31029c
--- /dev/null
+++ b/chrome/browser/download/mhtml_generation_manager.h
@@ -0,0 +1,80 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_
+#define CHROME_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_
+
+#include <map>
+
+#include "base/memory/ref_counted.h"
+#include "base/platform_file.h"
+#include "base/process.h"
+#include "content/browser/browser_thread.h"
+
+class FilePath;
+class TabContents;
+
+class MHTMLGenerationManager
+    : public base::RefCountedThreadSafe<MHTMLGenerationManager,
+                                        BrowserThread::DeleteOnUIThread> {

[Randy Smith (Not in Mondays), 2011/06/10 19:49:58]

This seems like it's a leak in waiting.  If the generation manager is destroyed
(or might be destroyed) during shutdown, this won't work, because shutdown
happens after first returning from the UI MessageLoop::Run() call, and so the
message sent to the UI thread when the last reference to the object goes will
result in a message being sent to a non-existent thread, and no destruction.

[jam, 2011/06/10 20:25:06]

this is totally acceptable, and happens in lots of places in the code.  it's
assumed that with the usage of DeleteOnXThread that the delete might not happen.
 memory leaks on shutdown are fine.

+ public:
+  MHTMLGenerationManager();
+  ~MHTMLGenerationManager();
+
+  // Instructs the render view to generate a MHTML representation of the current
+  // page for |tab_contents|.
+  void GenerateMHTML(TabContents* tab_contents, const FilePath& file);
+
+  // Notification from the renderer that the MHTML generation succeeded/failed.
+  void MHTMLGenerated(int job_id, bool success);
+
+  // The details sent along with the MHTML_GENERATED notification.
+  struct NotificationDetails {
+    FilePath file_path;
+    bool success;
+  };
+
+ private:
+  struct Job{
+    Job();
+
+    FilePath file_path;
+
+    // The handles to file the MHTML is saved to, for the browser and renderer
+    // processes.
+    base::PlatformFile browser_file;
+    base::PlatformFile renderer_file;
+
+    // The IDs mapping to a specific tab.
+    int process_id;
+    int routing_id;
+  };
+
+  // Called on the file thread to create |file|.
+  void CreateFile(int job_id,
+                  const FilePath& file,
+                  base::ProcessHandle renderer_process);
+
+  // Called on the UI thread when the file that should hold the MHTML data has
+  // been created.  This returns a handle to that file for the browser process
+  // and one for the renderer process. These handles are
+  // kInvalidPlatformFileValue if the file could not be opened.
+  void FileCreated(int job_id,
+                   base::PlatformFile browser_file,
+                   base::PlatformFile renderer_file);
+
+  // Called on the file thread to close the file the MHTML was saved to.
+  void CloseFile(base::PlatformFile file);
+
+  // Called on the UI thread when a job has been processed (successfully or
+  // not).  Closes the file and removes the job from the job map.
+  void JobFinished(int job_id, bool success);
+
+  typedef std::map<int, Job> IDToJobMap;
+  IDToJobMap id_to_job_;
+
+  DISALLOW_COPY_AND_ASSIGN(MHTMLGenerationManager);
+};
+
+#endif  // CHROME_BROWSER_DOWNLOAD_MHTML_GENERATION_MANAGER_H_