Minor cleanup of StoreBuffer related heap iteration methods.

Minor cleanup of StoreBuffer related heap iteration methods.

Now ObjectSlotCallbacks just update the slot and caller takes care of StoreBuffer updates.

This allows to remove ugly HEAP macros in couple of places and streamline the whole implementation.

Committed: http://code.google.com/p/v8/source/detail?r=8276

[Erik Corry, 2011-06-13 08:16:39]

LGTM

http://codereview.chromium.org/7044082/diff/1/src/store-buffer.cc
File src/store-buffer.cc (right):

http://codereview.chromium.org/7044082/diff/1/src/store-buffer.cc#newcode407
src/store-buffer.cc:407: // TODO(gc) ISOLATES MERGE
Let's just delete this comment.

http://codereview.chromium.org/7044082/diff/1/src/store-buffer.cc#newcode575
src/store-buffer.cc:575: // May be invalid if object is not in new space.
It may well be me that wrote this, but I can't remember any more why we can't
just delete this comment and move the line below into the 'if'.

http://codereview.chromium.org/7044082/diff/1/src/store-buffer.h
File src/store-buffer.h (right):

http://codereview.chromium.org/7044082/diff/1/src/store-buffer.h#newcode165
src/store-buffer.h:165: // All pages will be marked as having invalid watermark
upon
Given that we don't have watermarks any more, this comment should probably just
be deleted.