Issue 704393002: Add LOCAL_PICKUP_FILES to dm and bench makefiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 704393002: Add LOCAL_PICKUP_FILES to dm and bench makefiles. (Closed)

Created:
6 years, 1 month ago by scroggo

Modified:
6 years, 1 month ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add LOCAL_PICKUP_FILES to dm and bench makefiles. Update the generator to include a line for LOCAL_PICKUP_FILES. When generating makefiles for our tests, they will now have the following line: LOCAL_PICKUP_FILES := \ $(LOCAL_PATH)/../resources This allows testing infrastructure to pick up resource files used by our tests. Update expectations files to test LOCAL_PICKUP_FILES. BUG=skia:2454 Committed: https://skia.googlesource.com/skia/+/978d37b343e7de470ce47017ee2b43fc04ea2061

Patch Set 1 #

Patch Set 2 : Simpler approach. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	platform_tools/android/gyp_gen/tool_makefile_writer.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	platform_tools/android/tests/expectations/tool/Android.mk	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704393002/20001

6 years, 1 month ago (2014-11-06 22:18:31 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-07 14:02:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 978d37b343e7de470ce47017ee2b43fc04ea2061

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages