Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 704393002: Add LOCAL_PICKUP_FILES to dm and bench makefiles. (Closed)

Created:
6 years, 1 month ago by scroggo
Modified:
6 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add LOCAL_PICKUP_FILES to dm and bench makefiles. Update the generator to include a line for LOCAL_PICKUP_FILES. When generating makefiles for our tests, they will now have the following line: LOCAL_PICKUP_FILES := \ $(LOCAL_PATH)/../resources This allows testing infrastructure to pick up resource files used by our tests. Update expectations files to test LOCAL_PICKUP_FILES. BUG=skia:2454 Committed: https://skia.googlesource.com/skia/+/978d37b343e7de470ce47017ee2b43fc04ea2061

Patch Set 1 #

Patch Set 2 : Simpler approach. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M platform_tools/android/gyp_gen/tool_makefile_writer.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M platform_tools/android/tests/expectations/tool/Android.mk View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scroggo
6 years, 1 month ago (2014-11-06 22:16:48 UTC) #2
mtklein
lgtm
6 years, 1 month ago (2014-11-06 22:17:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704393002/20001
6 years, 1 month ago (2014-11-06 22:18:31 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 14:02:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 978d37b343e7de470ce47017ee2b43fc04ea2061

Powered by Google App Engine
This is Rietveld 408576698