Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 704363004: Add an accessibility setting to expose password values. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/accessibility/AXRenderObject.cpp
diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp
index 58639de6792676352a73b738ad13d6ba8cc117b5..7222adc472e2d8d5160a8733878f1a1520bc79a0 100644
--- a/Source/core/accessibility/AXRenderObject.cpp
+++ b/Source/core/accessibility/AXRenderObject.cpp
@@ -846,7 +846,7 @@ AccessibilityOrientation AXRenderObject::orientation() const
String AXRenderObject::text() const
Mike West 2014/11/07 09:51:28 Is this ever exposed to JavaScript?
dmazzoni 2014/11/07 22:33:42 Nope.
{
- if (isPasswordField())
+ if (isPasswordFieldAndShouldHideValue())
return String();
return AXNodeObject::text();
@@ -857,7 +857,7 @@ int AXRenderObject::textLength() const
if (!isTextControl())
return -1;
- if (isPasswordField())
+ if (isPasswordFieldAndShouldHideValue())
return -1; // need to return something distinct from 0
return text().length();
@@ -916,7 +916,7 @@ String AXRenderObject::stringValue() const
if (!m_renderer)
return String();
- if (isPasswordField())
+ if (isPasswordFieldAndShouldHideValue())
return String();
RenderBoxModelObject* cssBox = renderBoxModelObject();
@@ -1645,7 +1645,7 @@ AXObject::PlainTextRange AXRenderObject::selectedTextRange() const
if (!isTextControl())
return PlainTextRange();
- if (isPasswordField())
+ if (isPasswordFieldAndShouldHideValue())
return PlainTextRange();
AccessibilityRole ariaRole = ariaRoleAttribute();

Powered by Google App Engine
This is Rietveld 408576698