Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: build/config/BUILD.gn

Issue 704363002: XXX test gn format everything (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/test/BUILD.gn ('k') | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index c51709c24ce97419a6be64241c616917c635e477..d9ab738c59ce3a0b6a9a8924a0ffb32e274ea857 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -30,8 +30,8 @@ declare_args() {
config("feature_flags") {
# TODO(brettw) most of these need to be parameterized.
defines = [
- "CHROMIUM_BUILD",
- "V8_DEPRECATION_WARNINGS", # Don't use deprecated V8 APIs anywhere.
+ "CHROMIUM_BUILD",
+ "V8_DEPRECATION_WARNINGS", # Don't use deprecated V8 APIs anywhere.
]
if (cld_version > 0) {
@@ -231,9 +231,7 @@ config("debug") {
}
config("release") {
- defines = [
- "NDEBUG",
- ]
+ defines = [ "NDEBUG" ]
}
# Default libraries ------------------------------------------------------------
@@ -268,6 +266,7 @@ config("default_libs") {
"winmm.lib",
"winspool.lib",
"ws2_32.lib",
+
# Please don't add more stuff here. We should actually be making this
# list smaller, since all common things should be covered. If you need
# some extra libraries, please just add a libs = [ "foo.lib" ] to your
@@ -284,7 +283,7 @@ config("default_libs") {
# '<!(<(android_toolchain)/*-gcc -print-libgcc-file-name)',
"c",
"dl",
- "m"
+ "m",
]
} else if (is_mac) {
libs = [
@@ -305,8 +304,6 @@ config("default_libs") {
"UIKit.framework",
]
} else if (is_linux) {
- libs = [
- "dl",
- ]
+ libs = [ "dl" ]
}
}
« no previous file with comments | « build/android/gyp/test/BUILD.gn ('k') | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698