Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: content/public/app/BUILD.gn

Issue 704363002: XXX test gn format everything (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/android/BUILD.gn ('k') | content/public/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # App different than the regular content subcomponents (see comments in 5 # App different than the regular content subcomponents (see comments in
6 # //content/BUILD.gn) because it has to support the browser/child process split 6 # //content/BUILD.gn) because it has to support the browser/child process split
7 # (the "both" target include both browser and child process files and is used 7 # (the "both" target include both browser and child process files and is used
8 # for testing). 8 # for testing).
9 # 9 #
10 # In non-component mode, browser, child, and both all follow the same structure: 10 # In non-component mode, browser, child, and both all follow the same structure:
(...skipping 19 matching lines...) Expand all
30 ] 30 ]
31 31
32 public_app_shared_deps = [ 32 public_app_shared_deps = [
33 "//base", 33 "//base",
34 "//base:i18n", 34 "//base:i18n",
35 "//content:export", 35 "//content:export",
36 "//content/public/common:common_sources", 36 "//content/public/common:common_sources",
37 ] 37 ]
38 38
39 if (is_component_build) { 39 if (is_component_build) {
40
41 source_set("both_sources") { 40 source_set("both_sources") {
42 # Only the main content shared library can pull this in. 41 # Only the main content shared library can pull this in.
43 visibility = [ "//content:content" ] 42 visibility = [ "//content:content" ]
44 43
45 sources = public_app_shared_sources 44 sources = public_app_shared_sources
46 45
47 configs += [ "//content:content_implementation" ] 46 configs += [ "//content:content_implementation" ]
48 47
49 deps = public_app_shared_deps + [ 48 deps = public_app_shared_deps + [
50 "//content/app:both", 49 "//content/app:both",
51 "//content/public/browser:browser_sources", 50 "//content/public/browser:browser_sources",
52 ] 51 ]
53 } 52 }
54 53
55 # These all just forward to content, which in turn depends on "both_sources". 54 # These all just forward to content, which in turn depends on "both_sources".
56 group("browser") { 55 group("browser") {
57 deps = [ "//content" ] 56 deps = [
57 "//content",
58 ]
58 } 59 }
59 group("child") { 60 group("child") {
60 deps = [ "//content" ] 61 deps = [
62 "//content",
63 ]
61 } 64 }
62 group("both") { 65 group("both") {
63 deps = [ "//content" ] 66 deps = [
67 "//content",
68 ]
64 } 69 }
65
66 } else { 70 } else {
67
68 # content_main_delegate.cc conditionally includes content_browser_client.h 71 # content_main_delegate.cc conditionally includes content_browser_client.h
69 # from //content/public/browser when it's not the child build. However, 72 # from //content/public/browser when it's not the child build. However,
70 # the header checker doesn't know this doesn't apply and throws an error. 73 # the header checker doesn't know this doesn't apply and throws an error.
71 # So all of these targets set check_includes = false. 74 # So all of these targets set check_includes = false.
72 # 75 #
73 # TODO(brettw) either teach the header checker to understand simple 76 # TODO(brettw) either teach the header checker to understand simple
74 # ifdefs or split the file apart so we can enable header checking here. 77 # ifdefs or split the file apart so we can enable header checking here.
75 # Furthermore, since this file exists in more than one target, they all 78 # Furthermore, since this file exists in more than one target, they all
76 # have to opt-out of header checking (a file is checked once for all 79 # have to opt-out of header checking (a file is checked once for all
77 # targets using a source file). 80 # targets using a source file).
78 81
79 source_set("both") { 82 source_set("both") {
80 check_includes = false # See comment above. 83 check_includes = false # See comment above.
81 84
82 sources = public_app_shared_sources 85 sources = public_app_shared_sources
83 configs += [ "//content:content_implementation" ] 86 configs += [ "//content:content_implementation" ]
84 deps = public_app_shared_deps + [ 87 deps = public_app_shared_deps + [
85 "//content/app:both", 88 "//content/app:both",
86 "//content/public/browser", 89 "//content/public/browser",
87 "//content/public/common", 90 "//content/public/common",
88 ] 91 ]
89 } 92 }
90 93
91 # TODO(GYP) enable chrome_multiple_dll support 94 # TODO(GYP) enable chrome_multiple_dll support
92 is_chrome_multiple_dll = false 95 is_chrome_multiple_dll = false
93 96
94 if (is_chrome_multiple_dll) { 97 if (is_chrome_multiple_dll) {
95 source_set("browser") { 98 source_set("browser") {
96 check_includes = false # See comment above. 99 check_includes = false # See comment above.
97 100
98 sources = public_app_shared_sources 101 sources = public_app_shared_sources
99 102
100 defines = [ "CHROME_MULTIPLE_DLL_BROWSER" ] 103 defines = [ "CHROME_MULTIPLE_DLL_BROWSER" ]
101 configs += [ "//content:content_implementation" ] 104 configs += [ "//content:content_implementation" ]
102 105
103 deps = public_app_shared_deps + [ 106 deps = public_app_shared_deps + [
104 "//content/app:browser", 107 "//content/app:browser",
105 "//content/public/browser", 108 "//content/public/browser",
106 "//content/public/common", 109 "//content/public/common",
107 ] 110 ]
108 } 111 }
109 112
110 source_set("child") { 113 source_set("child") {
111 check_includes = false # See comment above. 114 check_includes = false # See comment above.
112 115
113 sources = public_app_shared_sources 116 sources = public_app_shared_sources
114 117
115 defines = [ "CHROME_MULTIPLE_DLL_CHILD" ] 118 defines = [ "CHROME_MULTIPLE_DLL_CHILD" ]
116 configs += [ "//content:content_implementation" ] 119 configs += [ "//content:content_implementation" ]
117 120
118 deps = public_app_shared_deps + [ 121 deps = public_app_shared_deps + [
119 "//content/app:child", 122 "//content/app:child",
120 "//content/public/common", 123 "//content/public/common",
121 ] 124 ]
122 } 125 }
123 } else { 126 } else {
124 # When the multi-DLL build is disabled, there is only one type of the 127 # When the multi-DLL build is disabled, there is only one type of the
125 # "app" target, and "browser" and "child" are the same as "both". 128 # "app" target, and "browser" and "child" are the same as "both".
126 group("browser") { 129 group("browser") {
127 deps = [ ":both" ] 130 deps = [
131 ":both",
132 ]
128 } 133 }
129 group("child") { 134 group("child") {
130 deps = [ ":both" ] 135 deps = [
136 ":both",
137 ]
131 } 138 }
132 } 139 }
133
134 } 140 }
OLDNEW
« no previous file with comments | « content/public/android/BUILD.gn ('k') | content/public/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698