Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 704323002: Fix Quick share menu item. (Closed)

Created:
6 years, 1 month ago by aurimas (slooooooooow)
Modified:
6 years, 1 month ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Quick share menu item. title_button_menu_item should not be tinted by default, it should only be tinted when it is used as a menu. BUG=430789 Committed: https://crrev.com/55a7faf3ba4860b2556303efdd03f01a9ea5447e Cr-Commit-Position: refs/heads/master@{#303049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/res/layout/title_button_menu_item.xml View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
Hey Newton, PTAL. Aurimas
6 years, 1 month ago (2014-11-06 17:27:07 UTC) #2
newt (away)
Hey Aurimas, lgtm. Newton
6 years, 1 month ago (2014-11-06 17:41:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704323002/1
6 years, 1 month ago (2014-11-06 17:43:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-06 18:28:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 18:29:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55a7faf3ba4860b2556303efdd03f01a9ea5447e
Cr-Commit-Position: refs/heads/master@{#303049}

Powered by Google App Engine
This is Rietveld 408576698