Issue 704293002: Enable inlining tests that pass with new scheduler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 704293002: Enable inlining tests that pass with new scheduler. (Closed)

Created:
6 years, 1 month ago by Michael Starzinger

Modified:
6 years, 1 month ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Enable inlining tests that pass with new scheduler. R=titzer@chromium.org TEST=test-run-inlining/InlineTwiceDependentDiamond Committed: https://code.google.com/p/v8/source/detail?r=25205

Patch Set 2 : Yeah, well, that's just like, your opinion man. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	src/compiler/schedule.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	test/cctest/cctest.status	View	1	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm https://codereview.chromium.org/704293002/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/704293002/diff/1/test/cctest/cctest.status#newcode84 test/cctest/cctest.status:84: # TODO(sigurds): The scheduler cannot handle free-floating loops ...

6 years, 1 month ago (2014-11-06 16:51:15 UTC) #2

Michael Starzinger

https://codereview.chromium.org/704293002/diff/1/test/cctest/cctest.status File test/cctest/cctest.status (right): https://codereview.chromium.org/704293002/diff/1/test/cctest/cctest.status#newcode84 test/cctest/cctest.status:84: # TODO(sigurds): The scheduler cannot handle free-floating loops yet. ...

6 years, 1 month ago (2014-11-06 16:54:28 UTC) #3

Michael Starzinger

6 years, 1 month ago (2014-11-06 18:56:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 25205 (presubmit successful).

Expand Messages | Collapse Messages

Issue 704293002: Enable inlining tests that pass with new scheduler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Yeah, well, that's just like, your opinion man. #

Messages