Source/devtools/front_end/timeline/TimelinePanel.js - Issue 704233002: Revert of DevTools: don't change current selection on Timeline flame chart when overview window changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 704233002: Revert of DevTools: don't change current selection on Timeline flame chart when overview window changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js

index 37381f04898119b20e679005933b2acd08db8c7d..d540901a91ad02b1da51accaa6c4f05422cc7dc6 100644

--- a/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -985,14 +985,8 @@

_updateSelectionDetails: function()

{

- if (!this._selection) {

- if (this._tracingTimelineModel && this._flameChartEnabledSetting.get()) {

- this.showInDetails(this.element.ownerDocument.createElement("div"));

- return;

- } else {

- this._selection = WebInspector.TimelineSelection.fromRange(this._windowStartTime, this._windowEndTime);

- }

+ if (!this._selection)

+ this._selection = WebInspector.TimelineSelection.fromRange(this._windowStartTime, this._windowEndTime);

switch (this._selection.type()) {

case WebInspector.TimelineSelection.Type.Record:

« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | no next file » | no next file with comments »