Issue 704233002: Revert of DevTools: don't change current selection on Timeline flame chart when overview window changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 704233002: Revert of DevTools: don't change current selection on Timeline flame chart when overview window changes (Closed)

Created:
6 years, 1 month ago by pfeldman

Modified:
6 years, 1 month ago

Reviewers:
caseq, yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of DevTools: don't change current selection on Timeline flame chart when overview window changes (patchset #1 id:1 of https://codereview.chromium.org/695903002/) Reason for revert: There is a blocking issue of shift+drag being non discoverable that needs to be addressed first. Original issue's description: > DevTools: don't change current selection on Timeline flame chart when overview window changes > > Shift+drag is more convenient for specifying the range of interest it's better to avoid also binding the selection to the current range in the overview pane. > > Waterfall view will still populate its details view with the data for selected range in the overview pane. > > BUG=426152 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184904 TBR=loislo@chromium.org,caseq@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=426152 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184914

Patch Set 1 #

Created: 6 years, 1 month ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/devtools/front_end/timeline/TimelinePanel.js	View		1 chunk	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

pfeldman

6 years, 1 month ago (2014-11-06 14:04:00 UTC) #1

Created Revert of DevTools: don't change current selection on Timeline flame
chart when overview window changes

Expand Messages | Collapse Messages