Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: src/objects-inl.h

Issue 704183002: Fix for an assertion failure in Map::FindTransitionToField(...). Appeared after r25136. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-430846.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 85584c43e400f44eabb37ac66f96470efbbb72c2..0288bfb81b7e54558da93d22665009a8c30f7d1e 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1886,8 +1886,9 @@ Handle<Map> Map::FindTransitionToField(Handle<Map> map, Handle<Name> key) {
TransitionArray* transitions = map->transitions();
int transition = transitions->Search(FIELD, *key, NONE);
if (transition == TransitionArray::kNotFound) return Handle<Map>::null();
- DCHECK_EQ(FIELD, transitions->GetTargetDetails(transition).type());
- DCHECK_EQ(NONE, transitions->GetTargetDetails(transition).attributes());
+ PropertyDetails details = transitions->GetTargetDetails(transition);
+ if (details.type() != FIELD) return Handle<Map>::null();
+ DCHECK_EQ(NONE, details.attributes());
return Handle<Map>(transitions->GetTarget(transition));
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-430846.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698