Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 704133006: Cleanup: Remove FormWithElementIsAutofilled(). It's not used. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove FormWithElementIsAutofilled(). It's not used. Committed: https://crrev.com/e79b82168d940858ed2fcb96ba302c76871d1e87 Cr-Commit-Position: refs/heads/master@{#303613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -53 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 2 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
6 years, 1 month ago (2014-11-10 19:50:51 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 1 month ago (2014-11-10 22:12:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704133006/1
6 years, 1 month ago (2014-11-11 07:40:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 08:46:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 08:47:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e79b82168d940858ed2fcb96ba302c76871d1e87
Cr-Commit-Position: refs/heads/master@{#303613}

Powered by Google App Engine
This is Rietveld 408576698