Pepper: Add support for multicast in PPB_UDPSocket API

ppapi/tests/test_udp_socket_private.cc

Index: ppapi/tests/test_udp_socket_private.cc
diff --git a/ppapi/tests/test_udp_socket_private.cc b/ppapi/tests/test_udp_socket_private.cc
index ae1b978c298f5d48c8d782792a2ece06f39fadfd..e9f8306cc9b255357c6a94b662380b03f588afa2 100644
--- a/ppapi/tests/test_udp_socket_private.cc
+++ b/ppapi/tests/test_udp_socket_private.cc
@@ -58,6 +58,7 @@ void TestUDPSocketPrivate::RunTests(const std::string& filter) {
   RUN_CALLBACK_TEST(TestUDPSocketPrivate, ConnectFailure, filter);
   RUN_CALLBACK_TEST(TestUDPSocketPrivate, Broadcast, filter);
   RUN_CALLBACK_TEST(TestUDPSocketPrivate, SetSocketFeatureErrors, filter);
+  RUN_CALLBACK_TEST(TestUDPSocketPrivate, Multicast, filter);
 }
 
 std::string TestUDPSocketPrivate::GetLocalAddress(
@@ -164,6 +165,26 @@ std::string TestUDPSocketPrivate::PassMessage(pp::UDPSocketPrivate* target,
   PASS();
 }
 
+std::string TestUDPSocketPrivate::SetMulticastOptions(
+    pp::UDPSocketPrivate* socket) {
+  int32_t rv = socket->SetSocketFeature(
+      PP_UDPSOCKETFEATURE_PRIVATE_MULTICAST_LOOP, pp::Var(true));
+  if (rv != PP_OK)
+    return ReportError("PPB_UDPSocket_Private::SetSocketFeature", rv);
+
+  rv = socket->SetSocketFeature(PP_UDPSOCKETFEATURE_PRIVATE_MULTICAST_TTL,
+                                pp::Var(1));
+  if (rv != PP_OK)
+    return ReportError("PPB_UDPSocket_Private::SetSocketFeature", rv);
+
+  rv = socket->SetSocketFeature(PP_UDPSOCKETFEATURE_PRIVATE_MULTICAST_IF,
+                                pp::Var(1));
+  if (rv != PP_OK)
+    return ReportError("PPB_UDPSocket_Private::SetSocketFeature", rv);
+
+  PASS();
+}
+
 std::string TestUDPSocketPrivate::TestConnect() {
   pp::UDPSocketPrivate server_socket(instance_), client_socket(instance_);
   PP_NetAddress_Private server_address, client_address;
@@ -256,4 +277,12 @@ std::string TestUDPSocketPrivate::TestSetSocketFeatureErrors() {
                                pp::Var(1));
   ASSERT_EQ(PP_ERROR_BADARGUMENT, rv);
   PASS();
+

[ygorshenin1, 2014/11/14 08:03:43]

nit: remove the blank line.

[etrunko, 2014/11/17 17:45:10]

Done.

+}
+std::string TestUDPSocketPrivate::TestMulticast() {

[ygorshenin1, 2014/11/14 08:03:43]

nit: insert a blank line before #282.

[etrunko, 2014/11/17 17:45:10]

Done.

+  pp::UDPSocketPrivate server1(instance_), server2(instance_);

[ygorshenin1, 2014/11/14 08:03:43]

Could you please clarify why these sockets are called server1 and server2 and
why do you need two sockets at all?

[etrunko, 2014/11/17 17:45:10]

Oh, sorry, i submitted this test unfinished. It was just a stub.

+
+  ASSERT_SUBTEST_SUCCESS(SetMulticastOptions(&server1));
+  ASSERT_SUBTEST_SUCCESS(SetMulticastOptions(&server2));
+  PASS();
 }