Pepper: Add support for multicast in PPB_UDPSocket API

ppapi/proxy/udp_socket_resource_base.h

Index: ppapi/proxy/udp_socket_resource_base.h
diff --git a/ppapi/proxy/udp_socket_resource_base.h b/ppapi/proxy/udp_socket_resource_base.h
index 9e75ae73d95580aaf07f8c478942d0e99b561cfc..61ed66478048d4bf4b503c17b15c1ef753d15f79 100644
--- a/ppapi/proxy/udp_socket_resource_base.h
+++ b/ppapi/proxy/udp_socket_resource_base.h
@@ -73,6 +73,10 @@ class PPAPI_PROXY_EXPORT UDPSocketResourceBase: public PluginResource {
                      const PP_NetAddress_Private* addr,
                      scoped_refptr<TrackedCallback> callback);
   void CloseImpl();
+  int32_t JoinGroupImpl(const PP_NetAddress_Private *group,
+                        scoped_refptr<TrackedCallback> callback);

[dcheng, 2015/03/05 15:34:49]

As an aside, it's slightly more efficient to pass a scoped_refptr<T> as const
scoped_refptr<T>&, as it avoids a copy and a refcount increment/decrement for
the copied argument.

That being said, Chromium code (by a 2:1) ratio uses scoped_refptr<T> instead of
const scoped_refptr<T>& in function parameter lists, so it's probably not worth
changing this (especially since there are some long-term plans to make
scoped_refptr<T> moveable).

[dcheng, 2015/03/05 15:34:49]

As an aside, it's slightly more efficient to pass a scoped_refptr<T> as const
scoped_refptr<T>&, as it avoids a copy and a refcount increment/decrement for
the copied argument.

That being said, Chromium code (by a 2:1) ratio uses scoped_refptr<T> instead of
const scoped_refptr<T>& in function parameter lists, so it's probably not worth
changing this (especially since there are some long-term plans to make
scoped_refptr<T> moveable).

[etrunko, 2015/03/05 17:07:12]

Acknowledged.

+  int32_t LeaveGroupImpl(const PP_NetAddress_Private *group,
+                         scoped_refptr<TrackedCallback> callback);
 
  private:
   struct RecvBuffer {
@@ -88,8 +92,8 @@ class PPAPI_PROXY_EXPORT UDPSocketResourceBase: public PluginResource {
   void PostAbortIfNecessary(scoped_refptr<TrackedCallback>* callback);
 
   // IPC message handlers.
-  void OnPluginMsgSetOptionReply(scoped_refptr<TrackedCallback> callback,
-                                 const ResourceMessageReplyParams& params);
+  void OnPluginMsgGeneralReply(scoped_refptr<TrackedCallback> callback,
+                               const ResourceMessageReplyParams& params);
   void OnPluginMsgBindReply(const ResourceMessageReplyParams& params,
                             const PP_NetAddress_Private& bound_addr);
   void OnPluginMsgPushRecvResult(const ResourceMessageReplyParams& params,