Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5596)

Unified Diff: chrome/test/ppapi/ppapi_browsertest.cc

Issue 704133005: Pepper: Add support for multicast in PPB_UDPSocket API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit tests, thunk code auto generated Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/ppapi/ppapi_browsertest.cc
diff --git a/chrome/test/ppapi/ppapi_browsertest.cc b/chrome/test/ppapi/ppapi_browsertest.cc
index d420b16214b9923c30b8f064500ff68d767fbf08..8ecfcc5aaaefc82639b554c38b20aa28a521c268 100644
--- a/chrome/test/ppapi/ppapi_browsertest.cc
+++ b/chrome/test/ppapi/ppapi_browsertest.cc
@@ -344,34 +344,38 @@ TEST_PPAPI_OUT_OF_PROCESS_WITH_SSL_SERVER(TCPSocketPrivateTrusted)
#define MAYBE_UDPSocket_Broadcast UDPSocket_Broadcast
#endif
-#define RUN_UDPSOCKET_SUBTESTS \
- RunTestViaHTTP( \
- LIST_TEST(UDPSocket_ReadWrite) \
- LIST_TEST(UDPSocket_SetOption) \
- LIST_TEST(MAYBE_UDPSocket_Broadcast) \
- LIST_TEST(UDPSocket_ParallelSend))
-
-IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, UDPSocket) {
- RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, UDPSocket) {
- RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, MAYBE_GLIBC(UDPSocket)) {
- RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTest, UDPSocket) {
- RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClNonSfiTest,
- MAYBE_PNACL_NONSFI(UDPSocket)) {
- RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTransitionalNonSfiTest,
- MAYBE_PNACL_TRANSITIONAL_NONSFI(UDPSocket)) {
- RUN_UDPSOCKET_SUBTESTS;
-}
-
+#define UDPSOCKET_TEST(_test) \
+ IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, _test) { \
+ RunTestViaHTTP(LIST_TEST(_test)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, _test) { \
+ RunTestViaHTTP(LIST_TEST(_test)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, MAYBE_GLIBC(_test)) { \
+ RunTestViaHTTP(LIST_TEST(_test)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTest, _test) { \
+ RunTestViaHTTP(LIST_TEST(_test)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClNonSfiTest, \
+ MAYBE_PNACL_NONSFI(_test)) { \
+ RunTestViaHTTP(LIST_TEST(_test)); \
+ } \
+ IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTransitionalNonSfiTest, \
+ MAYBE_PNACL_TRANSITIONAL_NONSFI(_test)) { \
+ RunTestViaHTTP(LIST_TEST(_test)); \
+ } \
+
+// Instead of one single test for all UDPSocket features (like it is done for
+// TCPSocket), split them into multiple, making it easier to isolate which tests
+// are failing.
+UDPSOCKET_TEST(UDPSocket_ReadWrite)
+UDPSOCKET_TEST(UDPSocket_SetOption)
+UDPSOCKET_TEST(UDPSocket_SetOption_1_0)
+UDPSOCKET_TEST(UDPSocket_SetOption_1_1)
+UDPSOCKET_TEST(MAYBE_UDPSocket_Broadcast)
+UDPSOCKET_TEST(UDPSocket_ParallelSend)
+UDPSOCKET_TEST(UDPSocket_Multicast)
// UDPSocketPrivate tests.
// UDPSocketPrivate_Broadcast is disabled for OSX because it requires root

Powered by Google App Engine
This is Rietveld 408576698