Pepper: Add support for multicast in PPB_UDPSocket API

chrome/test/ppapi/ppapi_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/path_service.h"
 #include "base/test/test_timeouts.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 300 matching lines @@
 
 // UDPSocket tests.
 // UDPSocket_Broadcast is disabled for OSX because it requires root
 // permissions on OSX 10.7+.
 #if defined(OS_MACOSX)
 #define MAYBE_UDPSocket_Broadcast DISABLED_UDPSocket_Broadcast
 #else
 #define MAYBE_UDPSocket_Broadcast UDPSocket_Broadcast
 #endif
 
-#define RUN_UDPSOCKET_SUBTESTS \
-  RunTestViaHTTP( \
-      LIST_TEST(UDPSocket_ReadWrite) \
-      LIST_TEST(UDPSocket_SetOption) \
-      LIST_TEST(MAYBE_UDPSocket_Broadcast) \
-      LIST_TEST(UDPSocket_ParallelSend))
+#define UDPSOCKET_TEST(_test) \
+  IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, _test) { \
+    RunTestViaHTTP(LIST_TEST(_test)); \
+  } \
+  IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, _test) { \
+    RunTestViaHTTP(LIST_TEST(_test)); \
+  } \
+  IN_PROC_BROWSER_TEST_F(PPAPINaClGLibcTest, MAYBE_GLIBC(_test)) { \
+    RunTestViaHTTP(LIST_TEST(_test)); \
+  } \
+  IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTest, _test) { \
+    RunTestViaHTTP(LIST_TEST(_test)); \
+  } \
+  IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClNonSfiTest, \
+                         MAYBE_PNACL_NONSFI(_test)) { \
+    RunTestViaHTTP(LIST_TEST(_test)); \
+  } \
+  IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTransitionalNonSfiTest, \
+                         MAYBE_PNACL_TRANSITIONAL_NONSFI(_test)) { \
+    RunTestViaHTTP(LIST_TEST(_test)); \
+  } \

[dcheng, 2015/03/09 21:14:33]

Omit the \ on this line, since it's the last (real) line of the macro

[etrunko, 2015/03/09 22:18:10]

Done.

 
-IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest, UDPSocket) {
-  RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClNewlibTest, UDPSocket) {
-  RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTest, UDPSocket) {
-  RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClNonSfiTest,
-                       MAYBE_PNACL_NONSFI(UDPSocket)) {
-  RUN_UDPSOCKET_SUBTESTS;
-}
-IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTransitionalNonSfiTest,
-                       MAYBE_PNACL_TRANSITIONAL_NONSFI(UDPSocket)) {
-  RUN_UDPSOCKET_SUBTESTS;
-}
-
+// Instead of one single test for all UDPSocket features (like it is done for
+// TCPSocket), split them into multiple, making it easier to isolate which tests
+// are failing.
+UDPSOCKET_TEST(UDPSocket_ReadWrite)
+UDPSOCKET_TEST(UDPSocket_SetOption)
+UDPSOCKET_TEST(UDPSocket_SetOption_1_0)
+UDPSOCKET_TEST(UDPSocket_SetOption_1_1)
+UDPSOCKET_TEST(MAYBE_UDPSocket_Broadcast)
+UDPSOCKET_TEST(UDPSocket_ParallelSend)
+UDPSOCKET_TEST(UDPSocket_Multicast)
 
 // UDPSocketPrivate tests.
 // UDPSocketPrivate_Broadcast is disabled for OSX because it requires root
 // permissions on OSX 10.7+.
 TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate_Connect)
 TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate_ConnectFailure)
 #if !defined(OS_MACOSX)
 TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate_Broadcast)
 #endif  // !defined(OS_MACOSX)
 TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(UDPSocketPrivate_SetSocketFeatureErrors)
@@ skipping 1063 matching lines @@
 #endif
 
 IN_PROC_BROWSER_TEST_F(MojoPPAPITest, MAYBE_MOJO(Mojo)) {
   RunTest();
 }
 
 IN_PROC_BROWSER_TEST_F(MojoPPAPITest, MAYBE_MOJO(MojoFailsWithoutFlag)) {
   RunTestWithoutFlag();
 }
 #endif