Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: Source/core/accessibility/AXObject.cpp

Issue 704083004: ARIA role 'form' is not supported. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding form role in isLandmarkRelated() Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 { "contentinfo", ContentInfoRole }, 69 { "contentinfo", ContentInfoRole },
70 { "dialog", DialogRole }, 70 { "dialog", DialogRole },
71 { "directory", DirectoryRole }, 71 { "directory", DirectoryRole },
72 { "grid", GridRole }, 72 { "grid", GridRole },
73 { "gridcell", CellRole }, 73 { "gridcell", CellRole },
74 { "columnheader", ColumnHeaderRole }, 74 { "columnheader", ColumnHeaderRole },
75 { "combobox", ComboBoxRole }, 75 { "combobox", ComboBoxRole },
76 { "definition", DefinitionRole }, 76 { "definition", DefinitionRole },
77 { "document", DocumentRole }, 77 { "document", DocumentRole },
78 { "rowheader", RowHeaderRole }, 78 { "rowheader", RowHeaderRole },
79 { "form", FormRole },
79 { "group", GroupRole }, 80 { "group", GroupRole },
80 { "heading", HeadingRole }, 81 { "heading", HeadingRole },
81 { "img", ImageRole }, 82 { "img", ImageRole },
82 { "link", LinkRole }, 83 { "link", LinkRole },
83 { "list", ListRole }, 84 { "list", ListRole },
84 { "listitem", ListItemRole }, 85 { "listitem", ListItemRole },
85 { "listbox", ListBoxRole }, 86 { "listbox", ListBoxRole },
86 { "log", LogRole }, 87 { "log", LogRole },
87 // "option" isn't here because it may map to different roles depending o n the parent element's role 88 // "option" isn't here because it may map to different roles depending o n the parent element's role
88 { "main", MainRole }, 89 { "main", MainRole },
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 183
183 bool AXObject::isLandmarkRelated() const 184 bool AXObject::isLandmarkRelated() const
184 { 185 {
185 switch (roleValue()) { 186 switch (roleValue()) {
186 case ApplicationRole: 187 case ApplicationRole:
187 case ArticleRole: 188 case ArticleRole:
188 case BannerRole: 189 case BannerRole:
189 case ComplementaryRole: 190 case ComplementaryRole:
190 case ContentInfoRole: 191 case ContentInfoRole:
191 case FooterRole: 192 case FooterRole:
193 case FormRole:
192 case MainRole: 194 case MainRole:
193 case NavigationRole: 195 case NavigationRole:
194 case RegionRole: 196 case RegionRole:
195 case SearchRole: 197 case SearchRole:
196 return true; 198 return true;
197 default: 199 default:
198 return false; 200 return false;
199 } 201 }
200 } 202 }
201 203
(...skipping 765 matching lines...) Expand 10 before | Expand all | Expand 10 after
967 return ToggleButtonRole; 969 return ToggleButtonRole;
968 if (ariaHasPopup()) 970 if (ariaHasPopup())
969 return PopUpButtonRole; 971 return PopUpButtonRole;
970 // We don't contemplate RadioButtonRole, as it depends on the input 972 // We don't contemplate RadioButtonRole, as it depends on the input
971 // type. 973 // type.
972 974
973 return ButtonRole; 975 return ButtonRole;
974 } 976 }
975 977
976 } // namespace blink 978 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698