Issue 704063002: Terminate and wait the worker thread in ~WebEmbeddedWorkerImpl()

Issue 704063002: Terminate and wait the worker thread in ~WebEmbeddedWorkerImpl() (Closed)

Created:
6 years, 1 month ago by Kunihiko Sakamoto

Modified:
6 years, 1 month ago

Reviewers:
haraken, horo

CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken, serviceworker-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Terminate and wait the worker thread in ~WebEmbeddedWorkerImpl() It is possible that termination of worker thread is not triggered by the time of WebEmbeddedWorkerImpl destruction. We should call WorkerThread::stop() before waiting for the termination of worker thread. BUG=426332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184900

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -5 lines)			Patch
M	Source/core/workers/WorkerThread.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/workers/WorkerThread.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/web/WebEmbeddedWorkerImpl.cpp	View	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Kunihiko Sakamoto

This is a reverse patch of https://codereview.chromium.org/684223004/ Patch Set 2 to 3.

6 years, 1 month ago (2014-11-06 04:39:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704063002/1

6 years, 1 month ago (2014-11-06 08:56:58 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-06 08:58:51 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184900

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages