Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 704043002: [ServiceWorker] Update cache.match/matchAll tests. (Closed)

Created:
6 years, 1 month ago by asanka
Modified:
6 years, 1 month ago
Reviewers:
bkelly, *jsbell
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cleanup-formatting
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Update cache.match/matchAll tests. Updates include: * Test that fragment part of URLs are ignored. * Add Cache.match tests for scenarios that were only being tested using Cache.matchAll. Currently all Cache.matchAll tests are failing due to the method not being implemented. * Add tests for URLs that contain embedded credentials. BUG=374802, 428970 R=jsbell, bkelly@mozilla.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185044

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -38 lines) Patch
M LayoutTests/http/tests/resources/testharness-helpers.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/cache-match-expected.txt View 1 1 chunk +45 lines, -24 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js View 1 9 chunks +178 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
asanka
6 years, 1 month ago (2014-11-06 00:49:02 UTC) #2
asanka
Updates to Cache.add/put/delete for checking if fragments are ignored is forthcoming.
6 years, 1 month ago (2014-11-06 00:50:05 UTC) #3
jsbell
one glitch, otherwise lgtm I didn't rigorously compare against the spec, though. I trust bkelly@ ...
6 years, 1 month ago (2014-11-07 01:00:56 UTC) #7
bkelly
Thanks for the patch! FYI, I plan to review and test this later today.
6 years, 1 month ago (2014-11-07 16:03:19 UTC) #8
asanka
https://codereview.chromium.org/704043002/diff/1/LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js File LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js (right): https://codereview.chromium.org/704043002/diff/1/LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js#newcode104 LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js:104: return cacheAll.match('not-present-in-the-cache') On 2014/11/07 01:00:56, jsbell wrote: > cacheAll.match ...
6 years, 1 month ago (2014-11-07 18:55:40 UTC) #9
bkelly
These changes look good to me. I ran the tests against my gecko implementation and ...
6 years, 1 month ago (2014-11-07 19:17:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704043002/40001
6 years, 1 month ago (2014-11-10 16:04:59 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 17:05:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 185044

Powered by Google App Engine
This is Rietveld 408576698