Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 704013002: MIPS: Fix uint32div bug after r25103. (Closed)

Created:
6 years, 1 month ago by paul.l...
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Fix uint32div bug after r25103. The div and mod instructions on MIPS are not safe for rhs 0. TEST=test/mjsunit/asm/uint32div.js BUG= R=akos.palfi@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=25174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
paul.l...
PTAL.
6 years, 1 month ago (2014-11-05 22:36:14 UTC) #2
akos.palfi.imgtec
lgtm
6 years, 1 month ago (2014-11-05 22:45:52 UTC) #3
paul.l...
6 years, 1 month ago (2014-11-05 22:48:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698