Source/core/page/EventHandler.cpp - Issue 703983002: Add preventPropagation bit to GestureScrollUpdate event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 703983002: Add preventPropagation bit to GestureScrollUpdate event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Revert some unnecessary whitespace change Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 824ae35d027e5e07ee0809738e5ffff2216c2d3b..4041de47d946c504de764d0fe6ee4c858bd43160 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -2445,7 +2445,8 @@ bool EventHandler::handleGestureScrollUpdate(const PlatformGestureEvent& gesture

RefPtrWillBeRawPtr<FrameView> protector(m_frame->view());

Node* stopNode = nullptr;

- bool scrollShouldNotPropagate = gestureEvent.type() == PlatformEvent::GestureScrollUpdateWithoutPropagation;

+ bool scrollShouldNotPropagate = gestureEvent.type() == PlatformEvent::GestureScrollUpdateWithoutPropagation

+ || (gestureEvent.type() == PlatformEvent::GestureScrollUpdate && gestureEvent.preventPropagation());

// Try to send the event to the correct view.

if (passScrollGestureEventToWidget(gestureEvent, renderer)) {

« no previous file with comments | « no previous file | Source/platform/PlatformGestureEvent.h » ('j') | Source/web/tests/WebInputEventConversionTest.cpp » ('J')