Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: pkg/analyzer/lib/src/generated/source.dart

Issue 703963002: Use Element's source paths instead of URIs as a key in the index. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/index/store/split_store_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/source.dart
diff --git a/pkg/analyzer/lib/src/generated/source.dart b/pkg/analyzer/lib/src/generated/source.dart
index 47bb6205119d914e61f3b3c59dd05a6bf81528fd..4a2c29325a4aa37344cc4400bdad46ce0dbc32b6 100644
--- a/pkg/analyzer/lib/src/generated/source.dart
+++ b/pkg/analyzer/lib/src/generated/source.dart
@@ -638,8 +638,10 @@ class SourceFactory {
// Force the creation of an escaped URI to deal with spaces, etc.
return _internalResolveUri(containingSource, parseUriWithException(containedUri));
} catch (exception, stackTrace) {
+ String containingFullName =
+ containingSource != null ? containingSource.fullName : '<null>';
AnalysisEngine.instance.logger.logError(
- "Could not resolve URI ($containedUri) relative to source (${containingSource.fullName})",
+ "Could not resolve URI ($containedUri) relative to source ($containingFullName)",
new CaughtException(exception, stackTrace));
return null;
}
« no previous file with comments | « pkg/analysis_server/test/services/index/store/split_store_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698