Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 703893004: Implement IPP model support in udp_proxy (Closed)

Created:
6 years, 1 month ago by Alpha Left Google
Modified:
6 years, 1 month ago
Reviewers:
hubbe, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement IPP model support in udp_proxy This change adds a new "ipp" model in udp_proxy. This model simulates a WiFi network environment with great variations of latency. The average rate is roughly rate is about 2mbits/s. BUG=430596 TEST=none Committed: https://crrev.com/3fd31aa01e3fde38947f6194da8a3a51b86944c4 Cr-Commit-Position: refs/heads/master@{#303982}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M media/cast/test/utility/udp_proxy.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
Alpha Left Google
6 years, 1 month ago (2014-11-05 20:42:51 UTC) #2
Alpha Left Google
Adding miu@ for review.
6 years, 1 month ago (2014-11-08 00:28:48 UTC) #4
Alpha Left Google
Ping for review again.
6 years, 1 month ago (2014-11-10 19:27:17 UTC) #5
hubbe
LGTM (I don't suppose you can add it to tap_proxy.cc too?) https://codereview.chromium.org/703893004/diff/1/media/cast/test/utility/udp_proxy_main.cc File media/cast/test/utility/udp_proxy_main.cc (right): ...
6 years, 1 month ago (2014-11-10 19:31:48 UTC) #6
miu
lgtm % one comment change: https://codereview.chromium.org/703893004/diff/1/media/cast/test/utility/udp_proxy.h File media/cast/test/utility/udp_proxy.h (right): https://codereview.chromium.org/703893004/diff/1/media/cast/test/utility/udp_proxy.h#newcode185 media/cast/test/utility/udp_proxy.h:185: // in latency that ...
6 years, 1 month ago (2014-11-11 00:40:04 UTC) #7
Alpha Left Google
On 2014/11/10 19:31:48, hubbe wrote: > LGTM > > (I don't suppose you can add ...
6 years, 1 month ago (2014-11-13 03:22:50 UTC) #8
Alpha Left Google
6 years, 1 month ago (2014-11-13 03:22:59 UTC) #9
Alpha Left Google
On 2014/11/13 03:22:59, Alpha wrote: Not really planning to add this to tap_proxy yet unless ...
6 years, 1 month ago (2014-11-13 03:23:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703893004/20001
6 years, 1 month ago (2014-11-13 03:25:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-13 04:13:59 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 04:14:40 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3fd31aa01e3fde38947f6194da8a3a51b86944c4
Cr-Commit-Position: refs/heads/master@{#303982}

Powered by Google App Engine
This is Rietveld 408576698