Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 703893003: Add suppression to valgrind.supp for fun:FcConfigEvaluate. (Closed)

Created:
6 years, 1 month ago by bungeman-skia
Modified:
6 years, 1 month ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add suppression to valgrind.supp for fun:FcConfigEvaluate. Any allocation under FcConfigValues will be 'lost'. Update the valgrind suppression to reflect this. Committed: https://skia.googlesource.com/skia/+/0737922ca249dde6187920f491fe2cf3a710cb68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/valgrind.supp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
e.g. http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/78/steps/dm/logs/stdio
6 years, 1 month ago (2014-11-05 14:28:24 UTC) #2
egdaniel
lgtm
6 years, 1 month ago (2014-11-05 14:28:44 UTC) #3
mtklein
On 2014/11/05 14:28:44, egdaniel wrote: > lgtm There any way to whitelist the whole libfontconfig ...
6 years, 1 month ago (2014-11-05 14:31:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703893003/1
6 years, 1 month ago (2014-11-05 14:35:38 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 14:44:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 0737922ca249dde6187920f491fe2cf3a710cb68

Powered by Google App Engine
This is Rietveld 408576698