Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 703893002: Don't use C++11's std::trunc and std::round, use the traditional C functions. (Closed)

Created:
6 years, 1 month ago by Sven Panne
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Don't use C++11's std::trunc and std::round, use the traditional C functions. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/arm/simulator-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Sven Panne
@torne: Could you check if this solves your GCC 4.2 problem?
6 years, 1 month ago (2014-11-05 10:24:34 UTC) #2
Benedikt Meurer
lgtm
6 years, 1 month ago (2014-11-05 10:32:51 UTC) #3
Sven Panne
Committed patchset #1 (id:1) manually as 25140 (presubmit successful).
6 years, 1 month ago (2014-11-05 10:41:54 UTC) #4
Torne
On 2014/11/05 10:24:34, Sven Panne wrote: > @torne: Could you check if this solves your ...
6 years, 1 month ago (2014-11-05 11:02:57 UTC) #5
Torne
6 years, 1 month ago (2014-11-05 15:33:34 UTC) #6
Message was sent while issue was closed.
On 2014/11/05 11:02:57, Torne wrote:
> On 2014/11/05 10:24:34, Sven Panne wrote:
> > @torne: Could you check if this solves your GCC 4.2 problem?
> 
> Unfortunately not, nobody on our team actually has a mac; the breakage was
just
> on a bot. This change addresses the two errors the bot is currently reporting,
> so it should be fine :)


Looks like it fixed it, I cherrypicked it downstream and the bot is happy.

Powered by Google App Engine
This is Rietveld 408576698