Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Issue 703883002: [turbofan] Fix missing machine type for float32/float64 array accesses. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix missing machine type for float32/float64 array accesses. TEST=mjsunit/asm R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M src/compiler/access-builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/asm/float32array-store-div.js View 1 chunk +16 lines, -0 lines 0 comments Download
A test/mjsunit/asm/float64array-store-div.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 1 month ago (2014-11-05 08:06:45 UTC) #1
Sven Panne
lgtm
6 years, 1 month ago (2014-11-05 08:14:10 UTC) #2
Benedikt Meurer
6 years, 1 month ago (2014-11-05 08:15:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698