Issue 70383014: Fixes cursor hiding bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 70383014: Fixes cursor hiding bug (Closed)

Created:
7 years, 1 month ago by sky

Modified:
7 years, 1 month ago

Reviewers:
ananta

CC:
chromium-reviews, tfarina, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes cursor hiding bug OnCursorVisibilityChanged may be invoked multiple times with the same value. Current windows implementation is effectively ref counted. We don't want that, instead it should show/hide based on most recent call. BUG=317496 TEST=none R=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235500

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	ui/views/widget/desktop_aura/desktop_root_window_host_win.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	ui/views/widget/desktop_aura/desktop_root_window_host_win.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/70383014/1

7 years, 1 month ago (2013-11-16 02:00:54 UTC) #3

sky

7 years, 1 month ago (2013-11-16 02:52:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r235500 (presubmit successful).