Issue 7038044: First step to remove scripting from PPP_Instance and PPB_Instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7038044: First step to remove scripting from PPP_Instance and PPB_Instance. (Closed)

Created:
9 years, 7 months ago by dmichael (off chromium)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove scripting from PPP_Instance and PPB_Instance (behind precompiler flag). Create 0.5 versions of the instance interfaces that are the default only if PPAPI_INSTANCE_REMOVE_SCRIPTING is defined. This is so [hopefully] plugins can opt in to the new version and migrate to InstancePrivate/VarPrivate more easily. BUG=82606 TEST=PPAPI tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86458

Patch Set 1 : Fix null pointer dereference #

Patch Set 2 : fixed copyright header #

Patch Set 3 : merge #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -102 lines)			Patch
M	ppapi/c/ppb_instance.h	View		3 chunks	+22 lines, -36 lines	0 comments	Download
M	ppapi/c/ppp_instance.h	View		3 chunks	+37 lines, -15 lines	0 comments	Download
M	ppapi/cpp/instance.h	View		3 chunks	+8 lines, -6 lines	0 comments	Download
M	ppapi/cpp/instance.cc	View		3 chunks	+16 lines, -14 lines	0 comments	Download
M	ppapi/cpp/module.cc	View		3 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View		3 chunks	+27 lines, -8 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View	1 2	5 chunks	+24 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1 2	5 chunks	+38 lines, -9 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_unittest.cc	View	1	3 chunks	+3 lines, -8 lines	0 comments	Download
M	webkit/plugins/ppapi/resource_tracker_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

I was wrong, this can go in before that NaCl dependency is fixed. When NaCl ...

9 years, 7 months ago (2011-05-24 15:47:06 UTC) #2

LGTM

Expand Messages | Collapse Messages