Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 703793003: Removing unused role IncrementorRole from blink. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
blink-reviews, dglazkov+blink, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing unused role IncrementorRole from blink. IncrementorRole is not used anywhere in blink as a role for html element or ARIA role to chromium. This CL depends on https://codereview.chromium.org/714063002/ BUG=385014 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185268

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/modules/accessibility/AXObject.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
shreeramk
Please review. Thanks!!
6 years, 1 month ago (2014-11-12 09:51:09 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-12 19:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/703793003/20001
6 years, 1 month ago (2014-11-13 03:58:23 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 04:38:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185268

Powered by Google App Engine
This is Rietveld 408576698